Fix -Werror=stringop-truncation build failure in fileutils.c#3348
Closed
AlxCzl wants to merge 1 commit into
Closed
Fix -Werror=stringop-truncation build failure in fileutils.c#3348AlxCzl wants to merge 1 commit into
AlxCzl wants to merge 1 commit into
Conversation
|
You are welcome to add an entry to the CHANGELOG.md as well |
06925b1 to
c29afcb
Compare
Contributor
Author
|
Wrong source branch, sorry. I will close and re-open another PR to make this cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strncat(tmp_fullpath, path, sizeof(tmp_fullpath) - 1)into a zero-initialized buffer triggers-Wstringop-truncationon newer GCC because the copy length equals the buffer size, so GCC flags it as potentially truncating.Replaced the
strncatchain with a singlesnprintfcall, which also fixes a secondary bug on the old line 3041 where the third argument tostrncatwasstrlen(tmp_fullpath) - 1(which is the current string length, not the remaining buffer space). In practice this means the append could overrun the buffer ifpathwas short andd_namewas long enough.Before:
After: